Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GPGSigner to intoto #471

Closed
jku opened this issue Nov 30, 2022 · 1 comment · Fixed by #486
Closed

Move GPGSigner to intoto #471

jku opened this issue Nov 30, 2022 · 1 comment · Fixed by #486
Assignees

Comments

@jku
Copy link
Collaborator

jku commented Nov 30, 2022

I think the plan is as follows (@lukpueh can correct):

This is done because the gpg key and signature have serialization formats that are not quite compatible with the specifications. The goal is:

  • intoto can keep supporting the current key and sig formats for backwards compat
  • we can later add more specification compatible GPG support into securesystemslib (but this won't be compatible with the format in intoto)
@lukpueh
Copy link
Member

lukpueh commented Nov 30, 2022

FYI: in-toto is not yet using GPGSigner, but calls securesystemslib.gpg.functions.create_signature directly. Given that python-tuf doesn't use GPGSigner either, and we don't make API promises to anyone else, I suggest we fix the GPGSigner in here to generate a spec-compatible a Signature, and also add a spec-compatible GPGKey here.

There is ongoing work, which uses a GPGSigner to sign DSSE envelopes and traditional in-toto metadata. It would actually be great if that was a spec-compliant one. DSSE is new and does not need to support the current incompatible format, and in-toto might as well create signatures in the new format as long as it can still verify old signatures.
(details in: #370 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants