[BUG-234642] Left and right clicking on a large inventory folder freezes the viewer for a few seconds

[sl-service-account]

Steps To Reproduce

• Login on an Inventory Extensions viewer

• Open inventory

• Left click on a large folder to select it.

• Then right click on a large folder.

  Observed Behaviour

• When left clicking on a large inventory folder, the viewer sometimes freezes for about half a second - this doesn't always reproduce.

• When right clicking on a large inventory folder, the viewer will freeze for a few seconds - this always reproduces.

• See linked demo video showing me reproduce the freeze when right clicking my inventory folder named !!!!! OLD TO SORT ROOT

• Attached screenshot of fast timers shows the problem is in "System messages" - though this probably isn't very useful info as fast timers are a bit shite.

  Expected Behaviour

  Not to have the viewer freeze when left or right clicking large inventory folders.

  Other Information

• Oddly, this bug doesn't reproduce when left & right clicking the root inventory folder.

• Bug only reproduces on inventory extensions viewers

Attachments

• Screenshot_1.png 2023-11-06 18:18:16

Original Jira Fields

Field	Value
Issue	BUG-234642
Summary	Left and right clicking on a large inventory folder freezes the viewer for a few seconds
Type	Bug
Priority	Unset
Status	Accepted
Resolution	Triaged
Labels	inventory_extensions
Reporter	Whirly Fizzle (whirly.fizzle)
Created at	2023-11-06T23:14:43Z
Updated at	2023-11-17T14:21:33Z

{
  'Build Id': 'unset',
  'Business Unit': ['Platform'],
  'Date of First Response': '2023-11-07T12:04:36.140-0600',
  'ReOpened Count': 0.0,
  'Severity': 'Unset',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': 'Filling in...',
  'What were you doing when it happened?': '....',
  'What were you expecting to happen instead?': '....',
  'Where': 'Any region',
}

[sl-service-account]

Dan Linden commented at 2023-11-07T18:04:36Z

Thank you for the report, Whirly!

[sl-service-account]

AndreyK ProductEngine commented at 2023-11-14T22:35:56Z

If possible, please try enabling "Develop->XUI->Show xui names" in fresh session before opening inventory and see if it makes left clicks on folders faster. 'Show names' should switch 'suffix' from doing expensive recursive content checks to direct descendants, so if delay goes away I will know for sure what was causing it.

I rewoked deletion checks to not be as performance intensive, can you please check if right clicks are any better? It pobably won't be a cure, but it makes things faster for me and I assume it will take a second instead of a couple for you (but it might be not the only issue that causes a delay).
https://github.com/secondlife/viewer/releases/tag/Second_Life_Release%237e66f6c-x

P.S. I'm checking out options for 'delayed' population of folder info and deletion checks since at the moment these seem to be the offenders.

[sl-service-account]

Whirly Fizzle commented at 2023-11-17T01:49:30Z

Hiya Andrey,

Testing on https://releasenotes.secondlife.com/viewer/6.6.16.6566955269.html
When "Develop->XUI->Show xui names" is enabled, I can no longer reproduce the small freeze when left clicking a large folder.
Right-clicking a large folder does still freeze the viewer for a few seconds though.

Testing on https://github.com/secondlife/viewer/releases/tag/Second_Life_Release%237e66f6c-x
I still have a stall when right clicking a large folder. Hard to say if it is better - possibly it's a bit of a shorter stall but hard to say.

[sl-service-account]

AndreyK ProductEngine commented at 2023-11-17T14:21:33Z

Ok, thank you. Will see what I can do about that.