Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeviceSize should contain iPad sizes too! #72

Open
revolter opened this issue Aug 17, 2017 · 3 comments
Open

DeviceSize should contain iPad sizes too! #72

revolter opened this issue Aug 17, 2017 · 3 comments

Comments

@revolter
Copy link

There's no reason why DeviceSize wouldn't have the iPad sizes too (9.7 and 12.9). If not, then it should be named iPhoneDeviceSize.
@filletofish
Copy link

@sebyddd any progress on this issue?

@JulesMoorhouse
Copy link

This would be awesome.
Idea for use in interface builder in preview.
When using drawing code.

@JulesMoorhouse
Copy link

I've added a PR for this #87
This also include simulator support for iPads from another PR.

You can use this in your podfile like so...

pod 'SDVersion', :git => 'https://github.com/Jules2010/SDVersion', :inhibit_warnings => true , :commit => '17b66e586cf555c95a307ce0cbb24952c3e3f91c'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JulesMoorhouse @revolter @filletofish