Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler Errors: No Defining Declaration #1196

Closed
ghost opened this issue Jun 16, 2022 · 5 comments
Closed

Compiler Errors: No Defining Declaration #1196

ghost opened this issue Jun 16, 2022 · 5 comments

Comments

@ghost
Copy link

ghost commented Jun 16, 2022

Hi there, I just got the latest from the main branch and locally (on mac - Visual Studio Preview) - I'm getting the following two compiler errors:

/Users/tcassidy/github/jint/Jint.Tests.Test262/TestHarness.cs(33,33): Error CS0759: No defining declaration found for implementing declaration of partial method 'TestHarness.InitializeCustomState()' (CS0759) (Jint.Tests.Test262)

/Users/tcassidy/github/jint/Jint.Tests.Test262/Test262Test.cs(26,26): Error CS0759: No defining declaration found for implementing declaration of partial method 'Test262Test.ShouldThrow(Test262File, bool)' (CS0759) (Jint.Tests.Test262)
@ghost
Copy link
Author

ghost commented Jun 16, 2022

If I back out to commit:

013a78a

(April 27th) - the compiler error concerning ShouldThrow(..) is no longer happening

@ghost
Copy link
Author

ghost commented Jun 16, 2022

And if I back out to commit:

3fa1f83

(March 23rd) - the compiler error concerning InitializeCustomizeState is gone.

Again - this is on Mac OS X - both from within visual studio and using the command line.

I have both .NET 6.0 and 3.1 installed locally. Validated by a coworker on their local machine.

@lahma
Copy link
Collaborator

lahma commented Jun 16, 2022

Did you check the readme in test262 project about how to generate the tests?

@ghost
Copy link
Author

ghost commented Jun 16, 2022

ah - sorry - yes that resolved it.

I made the mistake for not noticing the doc update.

For others - it is probably worthwhile adding:

  1. a build script for windows and linux/mac
  2. a section on the top level README.md called "Build Instructions" which references that script

Just a suggestion - as I say - this was my mistake - but would likely help others.

@lahma
Copy link
Collaborator

lahma commented Jun 19, 2022

@source-transformer I've merged a change to main that should now generate the missing test cases on first dotnet build, running dotnet clean should remove old ones and next build again should re-generate with current config.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant