Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate --dump-xdebug-filter and --prepend #4226

Closed
sebastianbergmann opened this issue May 13, 2020 · 0 comments
Closed

Deprecate --dump-xdebug-filter and --prepend #4226

sebastianbergmann opened this issue May 13, 2020 · 0 comments
Assignees
@sebastianbergmann
Labels
feature/code-coverage Issues related to code coverage (but not php-code-coverage) feature/test-runner CLI test runner type/deprecation Something will be/is deprecated
Milestone
PHPUnit 9.3

Comments

@sebastianbergmann
Copy link
Owner

sebastianbergmann commented May 13, 2020 •
edited
Loading

PHPUnit 7.4 introduced the --dump-xdebug-filter and --prepend command-line options for leveraging Xdebug's native filtering for faster code coverage.

The developer experience of using these options is not great as PHPUnit has to be invoked twice, once to generate the filter script and once for actually running the tests. Furthermore, the implementation of --prepend requires a hack that completely bypasses the regular argument parsing.

As @dvdoug explains in sebastianbergmann/php-code-coverage#747 (comment), almost the same effect can be achieved without requiring manual work. We should therefore get rid of --dump-xdebug-filter and --prepend.
@sebastianbergmann sebastianbergmann added feature/code-coverage Issues related to code coverage (but not php-code-coverage) type/deprecation Something will be/is deprecated labels May 13, 2020
@sebastianbergmann sebastianbergmann added this to the PHPUnit 9.2 milestone May 13, 2020
@sebastianbergmann sebastianbergmann self-assigned this May 13, 2020
@sebastianbergmann sebastianbergmann mentioned this issue May 13, 2020
Closed
@sebastianbergmann sebastianbergmann added the feature/test-runner CLI test runner label May 13, 2020
@sebastianbergmann sebastianbergmann mentioned this issue May 13, 2020
Closed
gbirke added a commit to wmde/fundraising-application that referenced this issue Jan 14, 2021
@gbirke
Remove PHPUnit coverage allow list generation
5b467f6 
PHPUnit deprecated the coverage list parameter (see sebastianbergmann/phpunit#4226) and our build script was throwing errors.
@gbirke gbirke mentioned this issue Jan 14, 2021
Merged
@pczerkas pczerkas mentioned this issue May 2, 2022
Closed
@maks-rafalko maks-rafalko mentioned this issue May 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianbergmann sebastianbergmann

Labels
feature/code-coverage Issues related to code coverage (but not php-code-coverage) feature/test-runner CLI test runner type/deprecation Something will be/is deprecated
Projects
None yet
Milestone
PHPUnit 9.3
Development

No branches or pull requests
1 participant
@sebastianbergmann