Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --fail-on-risky and --fail-on-warning commandline options as well as failOnRisky and failOnWarning configuration options #1905

Closed
sebastianbergmann opened this issue Oct 7, 2015 · 2 comments
Labels
type/enhancement A new idea that should be implemented
Milestone

Comments

@sebastianbergmann
Copy link
Owner

Use exit(PHPUnit_TextUI_TestRunner::FAILURE_EXIT); instead of exit(PHPUnit_TextUI_TestRunner::SUCCESS_EXIT); when there are no test failures and no test errors but risky tests or tests with warnings.

@sebastianbergmann sebastianbergmann added the type/enhancement A new idea that should be implemented label Oct 7, 2015
@sebastianbergmann sebastianbergmann added this to the PHPUnit 5.2 milestone Oct 7, 2015
@sebastianbergmann sebastianbergmann changed the title Implement --fail-on-risky, --fail-on-warning, --fail-on-skipped, and --fail-on-incomplete commandline options as well as failOnRisky, failOnWarning, failOnSkipped, and failOnIncomplete configuration options Implement --fail-on-risky and --fail-on-warning commandline options as well as failOnRisky and failOnWarning configuration options Oct 8, 2015
@rentalhost
Copy link

The line 148 broked phpunit because doRun() on line 89 will call it with only two arguments, and $exit argument is required. The fix is just append a = false on this.

@sebastianbergmann
Copy link
Owner Author

@rentalhost So that is what #2094 was about. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A new idea that should be implemented
Projects
None yet
Development

No branches or pull requests

2 participants