Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When building with GHCJS, test cases fail but results look ok #242

Open
ddssff opened this issue Jun 17, 2022 · 3 comments
Open

When building with GHCJS, test cases fail but results look ok #242

ddssff opened this issue Jun 17, 2022 · 3 comments

Comments

@ddssff
Copy link
Contributor

ddssff commented Jun 17, 2022

Because GHCJS has different word sizes, the equality tests that work in GHC fail. For example,

     13) Clay.Color.darken does not darken an HSL color past black
       expected: Hsla 154 0.787 9.2e-2 255.0
        but got: Hsla 154 0.787 9.2e-2 255.0

The tests must be using equality when "close enough" is what we need.

@turion
Copy link
Collaborator

turion commented Jun 25, 2022

That's a puzzling error message 😅 . So we'd first need a working CI check that runs clay on GHCJS, and then fix the tests. PRs welcome.

@ddssff
Copy link
Contributor Author

ddssff commented Jun 26, 2022

What is the situtation with CI these days? I lost track when travis disappeared.

@turion
Copy link
Collaborator

turion commented Jun 26, 2022

We have Github Actions with Ubuntu & cabal: https://github.com/sebastiaanvisser/clay/blob/master/.github/workflows/ci.yml But I have no idea whether one can GHCJS there. Maybe we should also reinstate the nix CI job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants