Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuck on loading when api is offline #15

Open
felipefreitag opened this issue Aug 7, 2018 · 0 comments
Open

Stuck on loading when api is offline #15

felipefreitag opened this issue Aug 7, 2018 · 0 comments

Comments

@felipefreitag
Copy link
Collaborator

Steps to reproduce:

  • Make a request when the api is offline
  • Croods will be stuck loading and won't show an error

Expected behavior:

  • It should show an error.
    screenshot from 2018-08-07 10-24-55

Currently, Croods supports only one type of error object. When the error is in another format, there is an unhandled promise warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant