Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newest version throws an error when trying to call sitemapper.fetch() #159

Open
graylewis opened this issue Nov 12, 2024 · 4 comments
Open

Comments

@graylewis
Copy link

We're using sitemapper on production and the most recent update broke our pipeline.

This is the code:

    const sitemapper = new Sitemapper({
      url: sitemapLocation,
      rejectUnauthorized: false,
    })
    const { sites, errors } = await sitemapper.fetch()

We had to rollback to 3.2.12 from 3.2.18 because it started throwing TypeError: Cannot read properties of undefined (reading 'sites')

Looking through the releases between 3.2.12-3.2.18, and the lack of a major version increment, I'm assuming this a bug and not a breaking change.

@graylewis
Copy link
Author

I can confirm that sitemapLocation was defined when the function was called

@peterholc
Copy link

I can confirm I'm having the same issues on 3.2.18, reverting to 3.2.12 fixed it for now.

@seantomburke
Copy link
Owner

Will get this fixed, apologies for the delay!

@seantomburke
Copy link
Owner

@graylewis @peterholc should be fixed now in 3.2.20 with #158.
Do you have the sitemap URL available to test this? Would like to increase the test coverage to ensure no future regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants