Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should deploy_key also be prefixed with namespace? #2

Closed
kategengler opened this issue Oct 13, 2015 · 0 comments
Closed

Should deploy_key also be prefixed with namespace? #2

kategengler opened this issue Oct 13, 2015 · 0 comments

Comments

@kategengler
Copy link
Contributor

Great job on this gem!

I started out using this today with ember-cli-deploy 0.5.x and the redis adapter, it seems that by default, the deploy keys are also prefixed. I had to make this change in the gem:

      def deploy_key
-      redis_client.get(current_key).presence || deployment_not_activated!
+      key = redis_client.get(current_key).presence || deployment_not_activated!
+      "#{namespace}:#{key}"
      end

Should those keys be prefixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant