Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic marking of a visited region while creating an adventure #306

Closed
dymek37 opened this issue Sep 8, 2024 · 5 comments · Fixed by #356
Closed

Automatic marking of a visited region while creating an adventure #306

dymek37 opened this issue Sep 8, 2024 · 5 comments · Fixed by #356
Assignees
Labels
backend Issues related to the Django backend enhancement New feature or request

Comments

@dymek37
Copy link
Contributor

dymek37 commented Sep 8, 2024

Hi,

I would like to suggest a new feature. Would it be possible to add an option to mark a region (administrative unit) as visited when creating a new adventure?

The idea would be as follows: in the location search field, I enter a name, and the system finds the appropriate location. After the search, information about the region to which the location belongs appears, along with a toggle to mark the region as visited.

Of course, this is just a suggestion, and I’m not sure if it’s feasible, but I believe it could be useful!

Thanks for considering my proposal!

@dymek37 dymek37 changed the title utomatic marking of a visited region while creating an adventure Automatic marking of a visited region while creating an adventure Sep 8, 2024
@seanmorley15
Copy link
Owner

Hi!,
This is actually currently a feature, but is very limited. Currently, only a few countries like USA and Canada are supported. Currently it uses a lot of GeoJSON to determine region but this is limited and takes a lot of work to setup. I am looking for a dataset or external API that can take coordinates and return the region. AdventureLog already uses OpenStreetMap Nominatim so it would be cool if I could leverage that instead.
This will be worked on, thanks!

@seanmorley15 seanmorley15 self-assigned this Sep 8, 2024
@seanmorley15 seanmorley15 added enhancement New feature or request backend Issues related to the Django backend labels Sep 8, 2024
@dymek37
Copy link
Contributor Author

dymek37 commented Sep 8, 2024

It would be great if it could be done! I’m keeping my fingers crossed!

@tigattack
Copy link

tigattack commented Sep 8, 2024

Could the Nominatim reverse endpoint do what AdventureLog needs? Or perhaps the OSM Overpass API?

@seanmorley15
Copy link
Owner

After doing some testing, the Nominatim reverse geocoding should do the trick for the most part. Due to the fact that its not always perfect, I will make it so it can prompt the user something like "Would you like to mark {region} as visited?" when they submit. The Nominatim API gives out the ISO codes that match what AdventureLog uses more times than not so this should be a cleaner and easier system.
I will work on this soon!

@seanmorley15 seanmorley15 added this to the AdventureLog v0.8.0 milestone Sep 30, 2024
@seanmorley15
Copy link
Owner

Hi everyone! Just had some time to implement this today! It is in the beta branch for further testing (although from my testing it works very well!). It will be released as a part of the next update.
image
Enjoy!

Also, any feedback or tweaks are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Issues related to the Django backend enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants