Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow with expr AS ident syntax in WITH clause #433

Closed
MawiraIke opened this issue Sep 22, 2022 · 1 comment
Closed

Allow with expr AS ident syntax in WITH clause #433

MawiraIke opened this issue Sep 22, 2022 · 1 comment
Assignees
@seancorfield
Labels
documentation I need to write something up!

Comments

@MawiraIke
Copy link
Contributor

As discussed in #428 , the expression passed to WITH clause in ClickHouse can be a string, which is not currently supported. When the expression is a string, the order of WITH clause is with expr AS ident and not the current with ident AS expr.
I have created a PR that will allow for both variants of ClickHouse i.e
with expr AS ident and with ident AS subquery-expr
@MawiraIke MawiraIke mentioned this issue Sep 22, 2022
Closed
@seancorfield seancorfield mentioned this issue Sep 22, 2022
Merged
@seancorfield
Copy link
Owner

Note: I'm going to leave this open until I've wordsmithed the docs a bit and updated the CHANGELOG. Thank you for the PR!

@seancorfield seancorfield self-assigned this Sep 23, 2022
@seancorfield seancorfield added the documentation I need to write something up! label Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seancorfield seancorfield

Labels
documentation I need to write something up!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seancorfield @MawiraIke