Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commits generated by grc are not properly signed #52

Open
Enter-tainer opened this issue Mar 16, 2021 · 2 comments · May be fixed by #53
Open

commits generated by grc are not properly signed #52

Enter-tainer opened this issue Mar 16, 2021 · 2 comments · May be fixed by #53
Assignees
Labels
bug Something isn't working

Comments

@Enter-tainer
Copy link

Enter-tainer commented Mar 16, 2021

By default, if signingKey is specified in ~/.gitconfig, git will automatically sign the commit using gpg. But when using grc, commits are not signed.

git log --show-signature

image

My gitconfig:

mgt in ~
❯ cat .gitconfig
[user]
    name = mgt
    email = mgt@oi-wiki.org
    signingKey = 7965BF43A2143DD26F1A4850362C4BEE95C1C2DF
[commit]
    gpgSign = true

I've searched git2's document, and I guess it is possible to implement this feature. See https://docs.rs/git2/0.13.17/git2/struct.Repository.html#method.commit_signed .

@Enter-tainer Enter-tainer changed the title commits generated by grc is not properly signed commits generated by grc are not properly signed Mar 16, 2021
@CoelacanthusHex
Copy link

I found a upstream discussion rust-lang/git2-rs#507 , hope it can help you.

@sdttttt sdttttt self-assigned this Mar 16, 2021
@sdttttt
Copy link
Owner

sdttttt commented Mar 16, 2021

Hi, @CoelacanthusHex, @Enter-tainer Thank you for your issue. i would support for this feature in the next release.

I underestimated the difficulty of this job, I will support it as soon as possible if it is feasible.இ௰இ

@sdttttt sdttttt added the bug Something isn't working label Mar 16, 2021
@sdttttt sdttttt linked a pull request Mar 17, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants