-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate doc building with workflow #314
Comments
Last time I used such an approach, there were two downsides:
But maybe there are solutions for this by now |
Yeah, I was inspired by the workflow that came with the Markdown presentation tool Marp, because of its simple PR preview support. It works like this:
Future changes regarding forks:
Due to the security issues of the first approach, waiting for the second one is probably best. |
The native github preview mechanism sounds promising. Do you also have a solution for keeping different versions (and linking to them from the documentation)? I used to have something like that in scirpy before I moved to RTD, using some javascript hacks, but it wasn't the most elegant solution: https://github.com/scverse/scirpy/blob/6ccaa6673d3d043e1e7988e5c92c037ad2ffc713/docs/versions.rst?plain=1#L13-L21 |
If RTD was a GitHub app, it would be super simple, but the way it is, maybe setting up sphinx-action + GitHub pages is easier? We could check.
Of course RTD has other advantages, such as /latest/ vs /stable/ and so on, which shouldn’t be ignored
The text was updated successfully, but these errors were encountered: