Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

svgHeight #200

Closed
QsROg8320 opened this issue Oct 16, 2018 · 3 comments
Closed

svgHeight #200

QsROg8320 opened this issue Oct 16, 2018 · 3 comments

Comments

@QsROg8320
Copy link

Thanks for your job. Can you make svgHeight like input property. I want to set svgHeight='100%' but I can't do it.

@scttcper
Copy link
Owner

🎉 This issue has been resolved in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@QsROg8320
Copy link
Author

Thanks, but, now it doesn't work, I think this part need to replace.

@Input() svgHeight: string | number = '25%';

 @Input() svgHeight: string | number = null;
  @Input() svgWidth: string | number = null;

this.svgWidth = this.width || '100%';

this.svgWidth =this.svgWidth==null?( this.width || '100%'):this.svgWidth;
this.svgHeight =this.svgHeight==null?( this.height || '25%'):this.svgHeight;

@scttcper
Copy link
Owner

Any string you pass in will be used instead. I think it’s probably string only not number

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants