Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plug-in not fetching metadata for episodes 101+ #8

Closed
pilar6195 opened this issue Mar 21, 2022 · 2 comments
Closed

Plug-in not fetching metadata for episodes 101+ #8

pilar6195 opened this issue Mar 21, 2022 · 2 comments

Comments

@pilar6195
Copy link

pilar6195 commented Mar 21, 2022

Plug-in is not fetching the metadata for episodes 101+ for shows with over 100 episodes in a season. Example being Hunter X Hunter.

From the looks of it you are using Jikan to fetch the MAL data. They do pagination for this endpoint and will only return 100 results which will require additional requests to fetch the rest of the data. The plug-in does not seem to account for this. It is noted in the v3 docs which you can find here under the "Remarks" section.

Also on a side note, the v3 Jikan api is deprecated. Should probably also migrate to the v4 api.

I would open a PR but I'm not really familiar with python.

@pilar6195 pilar6195 changed the title Not fetching metadata for anime with over 100 episodes. Plug-in not fetching metadata for episodes 101+ Mar 21, 2022
@sachaw
Copy link
Collaborator

sachaw commented Mar 21, 2022

Thanks for the investigating 🔎

I'll take a look at this tonight and hopefully push a fix.

@sachaw
Copy link
Collaborator

sachaw commented Mar 25, 2022

@pilar6195 4a4f313 is now in, Please try out https://github.com/sachaw/AniList.bundle/releases/tag/2.9
This should have addressed all of your points.

Please keep an eye out for any series not behaving as expected, Thanks.

@sachaw sachaw closed this as completed Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants