Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition away from switch case for determining keyboard layouts #399

Open
2 tasks done
henrikth93 opened this issue Feb 18, 2024 · 7 comments
Open
2 tasks done
Assignees
Labels
good first issue Good for newcomers hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed refactor Refactor code to improve quality

Comments

@henrikth93
Copy link
Member

Terms

Issue

The code in KeyboardKeys is currently using switch cases for setting various widths, we want to avoid using switch cases and instead use a more general solution, where we only set the width for the current keyboard being used.

Reference:

func adjustPadKeyWidth() {

scalarCapsLockKeyWidth = currentLanguage.scalarCapsLockKeyWidth
scalarReturnKeyWidth = currentLanguage.scalarReturnKeyWidth
scalarSpecialKeysWidth = currentLanguage.scalarSpecialKeysWidth
scalarReturnKeyWidth = currentLanguage.scalarReturnKeyWidth

This is a good first issue for GSoC

@andrewtavis andrewtavis moved this to Todo in Scribe Board Feb 23, 2024
@andrewtavis andrewtavis added good first issue Good for newcomers help wanted Extra attention is needed refactor Refactor code to improve quality labels Feb 23, 2024
@andrewtavis andrewtavis added the hacktoberfest Included as a part of Hacktoberfest label Sep 30, 2024
@helocordi
Copy link
Contributor

Hi @andrewtavis could I take this issue as my first good contribution ?

@andrewtavis
Copy link
Member

Assigning you here as well, @helocordi, but let's do the other one you're assigned first and then this one 😊

@mcrkgus
Copy link
Contributor

mcrkgus commented Dec 19, 2024

Hi @andrewtavis ! I’d like to tackle with this issue. Can I work on this issue? kindly assign it to me

@andrewtavis
Copy link
Member

Sure thing, @mcrkgus!

@andrewtavis
Copy link
Member

@helocordi, this one would need active testing, so let's let @mcrkgus give it a try :) Please let us know if you'd like to work on another issue!

@andrewtavis
Copy link
Member

And let us know if you have any questions or need some assistance, @mcrkgus 😊

@mcrkgus
Copy link
Contributor

mcrkgus commented Dec 19, 2024

Thanks for the opportunity! @andrewtavis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed refactor Refactor code to improve quality
Projects
Status: Todo
Development

No branches or pull requests

4 participants