Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Emoji autosuggest #276

Merged
merged 5 commits into from
Apr 2, 2023

Conversation

SaurabhJamadagni
Copy link
Collaborator

Contributor checklist

  • This pull request is on a separate branch and not the main branch
  • I have updated the CHANGELOG with a description of my changes for the upcoming release (if necessary)

Description

  • Added two extra buttons to command bar that are used for emojis. These are deactivated when autosuggest is active.
  • A simple loop appends the top two emojis for a given prefix. These emojis are then assigned as title to the emoji suggestion buttons.
  • Reused as many functions as possible to avoid writing redundant code.
  • Tested on iPhone 14 Pro, iPhone SE (3rd Gen) and iPad Pro (11")

@andrewtavis could you take a look at these changes? Thanks for your help along the way :)

Related issue

@andrewtavis andrewtavis self-requested a review April 2, 2023 10:35
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm, @SaurabhJamadagni! 👍🥳🚀 Only change that I made was resetting the emojis each time, as the way it was set up the emojis would be appended to a list that was never rewritten, so the first emoji suggestions someone got would be the only ones they'd see 🙃

@andrewtavis
Copy link
Member

Will take this in and do some minor changes to it all for styling and such :)

@andrewtavis andrewtavis merged commit ac07828 into scribe-org:main Apr 2, 2023
@SaurabhJamadagni
Copy link
Collaborator Author

Only change that I made was resetting the emojis each time,

Ahhh, I think I only reset it when the auto action keys were pressed. Should have also reset it when spacebar was pressed to begin a new word. Thanks for the fix @andrewtavis! 😄

@SaurabhJamadagni SaurabhJamadagni deleted the 51-emoji-suggest branch April 18, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants