Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deleted] Change select noun and preposition annotation features #17

Closed
andrewtavis opened this issue Nov 23, 2021 · 2 comments
Closed
Labels
good first issue Good for newcomers question Further information is requested wontfix This will not be worked on

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Nov 23, 2021

This issue could be closed if there is enough feedback that the current way the select noun and preposition annotation features work is ok.

The question is: should it annotate when the words are selected rather than needing to press the Scribe key? If so, then implementation could be discussed and tracked here. Initial feedback indicates that maybe these features do not need to be changed as there would be too much stuff happening in the UI at once (eventually there will also be autocorrect and autosuggest changes happening on selection). It might also not be appealing for the user to have Scribe features be triggered by actions that are not directly keyboard related.

@andrewtavis andrewtavis added good first issue Good for newcomers question Further information is requested labels Nov 23, 2021
@andrewtavis andrewtavis changed the title Feature: change select noun and preposition annotation features Feature: Change select noun and preposition annotation features Nov 23, 2021
@andrewtavis andrewtavis changed the title Feature: Change select noun and preposition annotation features Change select noun and preposition annotation features Jan 25, 2022
@andrewtavis
Copy link
Member Author

andrewtavis commented Jan 25, 2022

Closing this issue as the general feedback has been that the user should need to trigger all Scribe commands.

@andrewtavis
Copy link
Member Author

andrewtavis commented Jan 29, 2022

This could be opened later on as the functionality after #112 doesn't allow a user to use the Scribe key when text is selected, which is unexpected behavior. What might be best is that during an annotation the command mode would also be triggered such that the Scribe key would change to escape. Pressing escape could then also trigger the text being deselected such that the keyboard would switch back to a normal view and the Scribe key could then be used.

The above is likely best converted to a new issue though :)

@andrewtavis andrewtavis changed the title Change select noun and preposition annotation features [deleted] Change select noun and preposition annotation features Apr 7, 2023
@andrewtavis andrewtavis added the wontfix This will not be worked on label Apr 7, 2023
@andrewtavis andrewtavis changed the title [deleted] Change select noun and preposition annotation features [Deleted] Change select noun and preposition annotation features Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers question Further information is requested wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant