Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine genders into comma separated strings for noun queries #544

Open
2 tasks done
andrewtavis opened this issue Jan 7, 2025 · 5 comments
Open
2 tasks done

Combine genders into comma separated strings for noun queries #544

andrewtavis opened this issue Jan 7, 2025 · 5 comments
Assignees
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

Something that was recently realized when looking into the new datasets is that for noun queries we need to combine all possible genders into a comma separated string. This is because there are languages where the same word can have more than one gender or could also be its own plural. For Spanish as well, there's the situation where the masculine and the feminine of nouns are on the same item, meaning it will have both genders.

Contribution

This is maybe an issue that @axif0 can work on for Outreachy, but let's keep it in mind and it could also be open for the community if people have interest 😊

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed labels Jan 7, 2025
@you-think-you-know-me
Copy link
Contributor

Hey @andrewtavis , I would love to work on this issue. Can you please assign this to me.

@andrewtavis
Copy link
Member Author

Sure thing, @you-think-you-know-me :) The change for this would ideally be done within the optional gender blocks of the noun SPARQL queries. As of now we're just returning one, but we should return all of them separated by commas and in alphabetical order for their labels. Let us know if you have any questions here! 😊

@you-think-you-know-me
Copy link
Contributor

ok thanks

@you-think-you-know-me
Copy link
Contributor

@andrewtavis I have made the required changes. Please review my PR and let me know if any change is required. Also is there any slack channel where scribe data community discussions are held? Please let me know as I would be happy to be a part of it.

@andrewtavis
Copy link
Member Author

Looking forward to the review, @you-think-you-know-me! The Scribe community uses Matrix for communications, with our public channel being here. You'd be welcome to join, and if you've never used Matrix then we suggest using Element for your application (Matrix is a protocol that other apps use).

Looking forward to seeing you there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

2 participants