Possible improvement to function name lookups

[asgrim]

scout-apm-php-ext/scout_utils.c

Lines 21 to 47 in 1a5df8f

	const char* determine_function_name(zend_execute_data *execute_data)
	{
	int len;
	char *ret;
	if (!execute_data->func) {
	return strdup("<not a function call>");
	}
	if (execute_data->func->common.scope && execute_data->func->common.fn_flags & ZEND_ACC_STATIC) {
	DYNAMIC_MALLOC_SPRINTF(ret, len, "%s::%s",
	ZSTR_VAL(Z_CE(execute_data->This)->name),
	ZSTR_VAL(execute_data->func->common.function_name)
	);
	return ret;
	}
	if (Z_TYPE(execute_data->This) == IS_OBJECT) {
	DYNAMIC_MALLOC_SPRINTF(ret, len, "%s->%s",
	ZSTR_VAL(execute_data->func->common.scope->name),
	ZSTR_VAL(execute_data->func->common.function_name)
	);
	return ret;
	}
	return strdup(ZSTR_VAL(execute_data->func->common.function_name));
	}

beberlei suggested that we could possibly remove the need to form the "function name" every time if we make the lookup used a multi-dimensional array. Need to check all its use cases and see if it is indeed possible, as would be good to avoid allocating the string every time a function is called.