wrong return value from BaseDocument#_getHookPromises (array of arrays of promise instead of array of promise)

[royaltm]

Long story short: this really ruined my night:

camo/lib/base-document.js

Line 541 in b2bd984

hookPromises.push(_.invoke([this], hookName));

The typeless at its worst...

this will push an array with (a possible) promise into an array

hookPromises.push(_.invoke([this], hookName));

resulting in [[promise]] instead of [promise]

and this is bad, because
Promise.all([[promise]]) immediately succeeds.

So any error in ANY of this document hook's promise will be (possible silently) discarded!

why just not

hookPromises.push(this[hookName]());

or at least:

hookPromises = hookPromises.concat(_.invoke([this], hookName));

[scottwrobinson]

Thanks for bringing this up. I should be able to try out your fix tomorrow.

Thanks!

[scottwrobinson]

Also, if you can post any code that shows the error that would be great. Thanks!

[royaltm]

here you go