Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AS Master key derivations should use salt value with a random part #2168

Closed
sgmonroy opened this issue Nov 26, 2018 · 3 comments
Closed

AS Master key derivations should use salt value with a random part #2168

sgmonroy opened this issue Nov 26, 2018 · 3 comments
Labels
i/needs information Need more information from the reporter i/proposal A new idea requiring additional input and discussion

Comments

@sgmonroy
Copy link
Contributor

As suggested in rfc2898 section 4.1, the salt value should contain at least 8B of random data.

@sgmonroy sgmonroy added the BR label Nov 26, 2018
@kormat kormat removed the BR label Nov 26, 2018
@kormat kormat changed the title BR: Salt value should at least contain a random part AS Master key derivations should use salt value with a random part Nov 26, 2018
@scrye scrye removed the help wanted label Jan 28, 2020
@matzf
Copy link
Contributor

matzf commented May 27, 2022

I can't really see how this would work. Would we store the randomly generated salt along the master key (the "password")? It's not clear to me how this would help at all. After all, in our setup, the "hashed password" is not any more likely to be compromised than the "password" itself, nor does it make any difference which one is compromised.

A simpler option seems to be to assume that the master key has been generated as a sensible random key and not treat it as a password. If users want/need to set this based on a password, they can still run a PBKDF manually when setting up the master secret.

@matzf matzf added the i/proposal A new idea requiring additional input and discussion label Jun 10, 2022
@matzf matzf added the i/needs information Need more information from the reporter label Nov 9, 2022
@matzf
Copy link
Contributor

matzf commented Nov 9, 2022

@sgmonroy, what do you think about this now, 4 years later?

@matzf
Copy link
Contributor

matzf commented Mar 13, 2023

Closing, will be reconsidered as part of a design for forwarding key roll over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i/needs information Need more information from the reporter i/proposal A new idea requiring additional input and discussion
Projects
None yet
Development

No branches or pull requests

5 participants