Use pytest config in pyproject.toml in CI #7555
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be safe, as the pytest documentation [1] states that "rootdir is NOT used to modify sys.path/PYTHONPATH". So while the `--config-file` option affects the `rootdir`, it's not adding that directory to the PYTHONPATH where it could accidentally overwrite the installed package. This solution is somewhat unsatisfying. Personally, I think a better approach would be to switch to the src-layout. [1] https://docs.pytest.org/en/7.1.x/reference/customize.html?highlight=rootdir#initialization-determining-rootdir-and-configfile
lagru
force-pushed
the
no-pytest-config
branch
from
1099802 to
5eb180a
Compare
lagru
changed the title
I believe this warning disappeared with tifffile 2024.4.24 which added support for NumPy 2.
stefanv
changed the title
|
During the meeting @stefanv suggested to use a different approach and just not step out of the project directory. It was suggested that that may be outdated behavior from a long time ago. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #7554.
This should be safe, as the pytest documentation states that
So while the
--config-fileoption affects therootdir, it's not adding that directory to the PYTHONPATH where it could accidentally overwrite the installed package.Checklist
./doc/examplesfor new featuresRelease note
For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.