Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the "Disassemble Check" test #294

Closed
jpivarski opened this issue Dec 6, 2022 · 1 comment · Fixed by #284
Closed

Update the "Disassemble Check" test #294

jpivarski opened this issue Dec 6, 2022 · 1 comment · Fixed by #284
Assignees
Labels
bug The problem described is something that must be fixed tests More or better tests are needed
Milestone

Comments

@jpivarski
Copy link
Member

Vector Version

HEAD

Python Version

3.8.8

OS / Environment

GitHub Actions

Describe the bug

I ran the CI test suite on main to make sure that Awkward/Uproot updates aren't breaking anything. (I also made the—unchecked—assumption that CI is testing against Awkward and Uproot pre-releases. I'll have to check that as well.)

Anyway, the "Disassemble Check" failed. That one was pinned to a Python minor version (3.8) because it involves Python byte code. That's less scary than it sounds because this test is mostly checking expressions, and changes in expression byte code is minimal. Updating it will be a matter of getting a newer version of uncompyle6 (it now works with Pythons 3.9 and 3.10) and maybe making a small change to the test.

Steps to Reproduce

Run CI.

Expected Results

CI should not fail.

Observed Results

CI failed.

Relevant log output

https://github.com/scikit-hep/vector/actions/runs/3634233305/jobs/6132119346

Run actions/setup-python@v4
  with:
    python-version: [3](https://github.com/scikit-hep/vector/actions/runs/3634233305/jobs/6132119346#step:3:3).8.8
    check-latest: false
    token: ***
    update-environment: true
Version 3.8.8 was not found in the local cache
Error: Version 3.8.8 with arch x6[4](https://github.com/scikit-hep/vector/actions/runs/3634233305/jobs/6132119346#step:3:4) not found
The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json
@jpivarski jpivarski added bug (unverified) The problem described would be a bug, but needs to be triaged bug The problem described is something that must be fixed tests More or better tests are needed and removed bug (unverified) The problem described would be a bug, but needs to be triaged labels Dec 6, 2022
@jpivarski jpivarski self-assigned this Dec 6, 2022
@Saransh-cpp
Copy link
Member

Vector is currently only tested on awkward v1's ._v2.

A PR is open for v2 support (reviewed by @agoose77!) - #284. I re-ran the tests on this PR and they pass with rc6 - https://github.com/scikit-hep/vector/actions/runs/3506891827/jobs/6138148137.

I wanted to discuss a couple of points before merging the v2 support PR - #284 (comment).

Also, I see the issue template has some redundant fields. I'll trim it down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The problem described is something that must be fixed tests More or better tests are needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants