Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Python 3.10 and set cancel-in-progress to True #242

Closed
Saransh-cpp opened this issue Aug 17, 2022 · 1 comment · Fixed by #252
Closed

Test with Python 3.10 and set cancel-in-progress to True #242

Saransh-cpp opened this issue Aug 17, 2022 · 1 comment · Fixed by #252
Labels
good first issue Good for newcomers tests More or better tests are needed
Milestone

Comments

@Saransh-cpp
Copy link
Member

Vector supports Python 3.10, but the support is not tested in the CI -

fail-fast: false
matrix:
python-version:
- 3.6
- 3.7
- 3.8
- 3.9
name: Check Python ${{ matrix.python-version }}
steps:


Additionally, the cancel-in-progress field is set to ${{ startsWith(github.ref, 'refs/pull/') }} -

concurrency:
# Skip intermediate builds: always.
# Cancel intermediate builds: only if it is a pull request build.
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }}

which for some reason returns a string now (unverified bug/incorrect documentation, see - github/docs#19416).

I think it should be okay to set it to true as set here - https://github.com/scikit-hep/cookie/blob/main/%7B%7Bcookiecutter.project_name%7D%7D/.github/workflows/ci.yml#L18-L20.

@Saransh-cpp Saransh-cpp added good first issue Good for newcomers tests More or better tests are needed labels Aug 17, 2022
@Saransh-cpp Saransh-cpp added this to the v1.0.0 milestone Aug 29, 2022
@henryiii
Copy link
Member

henryiii commented Sep 5, 2022

Let's add 3.11 too, and do this before release.

@Saransh-cpp Saransh-cpp modified the milestones: v1.0.0, v0.9.0 Sep 5, 2022
@Saransh-cpp Saransh-cpp linked a pull request Sep 5, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers tests More or better tests are needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants