Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codemeta check in current version check workflow #1990

Closed
matthewfeickert opened this issue Sep 6, 2022 · 2 comments · Fixed by #1995
Closed

Update codemeta check in current version check workflow #1990

matthewfeickert opened this issue Sep 6, 2022 · 2 comments · Fixed by #1995
Assignees
Labels
bug Something isn't working CI CI systems, GitHub Actions

Comments

@matthewfeickert
Copy link
Member

The codemeta tests haven't run for a long time given that there have been API breaking changes for a long time, and so

- name: Verify requirements in codemeta.json
run: |
python -m pip install jq "codemetapy>=0.3.4"
codemetapy --no-extras pyhf > codemeta_generated.json
diff <(jq -S .softwareRequirements codemeta_generated.json) <(jq -S .softwareRequirements codemeta.json)

has been skipped. There have been large changes in codemetapy since v2.0 and at the moment it v2.2.0 doesn't seem to work with pyhf at all. I'll need to update this for the CI.

@matthewfeickert matthewfeickert added bug Something isn't working CI CI systems, GitHub Actions labels Sep 6, 2022
@matthewfeickert matthewfeickert self-assigned this Sep 6, 2022
@matthewfeickert
Copy link
Member Author

Need

codemetapy --inputtype python pyhf

and then to figure out how to do the equivalent of --no-extras.

@matthewfeickert
Copy link
Member Author

I've opened up proycon/codemetapy#24 to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI CI systems, GitHub Actions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant