Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify absolute vs relative for likelihood specification #1718

Closed
1 task done
kratsg opened this issue Dec 2, 2021 · 1 comment · Fixed by #1971
Closed
1 task done

Clarify absolute vs relative for likelihood specification #1718

kratsg opened this issue Dec 2, 2021 · 1 comment · Fixed by #1971
Assignees
@kratsg @matthewfeickert
Labels
docs Documentation related needs-triage Needs a maintainer to categorize and assign

Comments

@kratsg
Copy link
Contributor

kratsg commented Dec 2, 2021 •
edited
Loading

Summary

This was mentioned in an offline discussion by @hepstr but an example for histosys doesn't explicitly state the meaning of the specification/declaration. It would be nicer if we mentioned exactly what the effect is (a shift from nominal to 20 events in first bin and 15 events in second bin for up variation...)

Documentation Page Link

https://scikit-hep.org/pyhf/likelihood.html#correlated-shape-histosys

Code of Conduct

  • I agree to follow the Code of Conduct
@kratsg kratsg added docs Documentation related needs-triage Needs a maintainer to categorize and assign labels Dec 2, 2021
@alexander-held
Copy link
Member

related issue for staterror: #1018

@kratsg kratsg mentioned this issue Aug 30, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kratsg kratsg

@matthewfeickert matthewfeickert

Labels
docs Documentation related needs-triage Needs a maintainer to categorize and assign
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Clarify absolute/relative for histosys scikit-hep/pyhf
3 participants
@kratsg @matthewfeickert @alexander-held