From 9d6e7f976f7551bec62487c4e6beadd4fa40f47a Mon Sep 17 00:00:00 2001
From: Matthew Feickert <matthew.feickert@cern.ch>
Date: Fri, 9 Sep 2022 16:32:22 +0200
Subject: [PATCH] Add tests to guard against nan condition

---
 tests/test_infer.py | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/tests/test_infer.py b/tests/test_infer.py
index 92a3467585..8d06f57694 100644
--- a/tests/test_infer.py
+++ b/tests/test_infer.py
@@ -476,3 +476,37 @@ def test_fixed_poi(tmpdir, hypotest_args):
     pdf.config.param_set('mu').suggested_fixed = [True]
     with pytest.raises(pyhf.exceptions.InvalidModel):
         pyhf.infer.hypotest(*hypotest_args)
+
+
+def test_teststat_nan_guard():
+    # Example from Issue #1992
+    model = pyhf.simplemodels.uncorrelated_background(
+        signal=[1.0], bkg=[1.0], bkg_uncertainty=[1.0]
+    )
+    observations = [2]
+    test_poi = 0.0
+    data = observations + model.config.auxdata
+    init_pars = model.config.suggested_init()
+    par_bounds = model.config.suggested_bounds()
+    fixed_params = model.config.suggested_fixed()
+
+    test_stat = pyhf.infer.test_statistics.qmu_tilde(
+        test_poi, data, model, init_pars, par_bounds, fixed_params
+    )
+    assert test_stat == pytest.approx(0.0)
+    asymptotic_calculator = pyhf.infer.calculators.AsymptoticCalculator(
+        data, model, test_stat="qtilde"
+    )
+    # ensure not nan
+    assert ~np.isnan(asymptotic_calculator.teststatistic(test_poi))
+    assert asymptotic_calculator.teststatistic(test_poi) == pytest.approx(0.0)
+
+    # Example from Issue #529
+    model = pyhf.simplemodels.uncorrelated_background([0.005], [28.0], [5.0])
+    test_poi = 1.0
+    data = [28.0] + model.config.auxdata
+
+    test_results = pyhf.infer.hypotest(
+        test_poi, data, model, test_stat="qtilde", return_expected=True
+    )
+    assert all(~np.isnan(result) for result in test_results)