Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide macOS Monterey and Ventura wheels #814

Closed
nega0 opened this issue Dec 8, 2022 · 7 comments
Closed

Provide macOS Monterey and Ventura wheels #814

nega0 opened this issue Dec 8, 2022 · 7 comments

Comments

@nega0
Copy link

nega0 commented Dec 8, 2022

As I'm sure you're aware the Github actions runner image macos-latest still points to Big Sur. macos-12 is the runner image for Monterey. Up-to-date wheels would be super helpful for piping in iminuit and prevent issues like #813.

Unfortunately, as was unofficially announced just yesterday (actions/runner-images#6426 (comment)), the Ventura image won't be available until Q2. I can provide a Ventura self-hosted runner in the meantime.

@HDembinski
Copy link
Member

HDembinski commented Dec 12, 2022

@henryiii As the packaging expert, do you have thoughts on this?

@nega0 You seem to understand much more about this than I do. We can switch from macos-latest to macos-12 when building the wheels if that helps.

@henryiii
Copy link
Member

You do not need to build on the latest macOS. On macOS, you set MACOSX_DEPLOYMENT_TARGET to the oldest macOS you support, and the stdlib will only include binary components that support that version - or any newer version. So it's generally safe to upgrade to a newer macOS, but you do not need to. The only benefit is you might get access to newer header only changes (but this is C++11 IIRC, so unlikely to benefit). That's not the problem in that issue at all.

Wheels list some version they target, then they work on all newer versions, following the way macOS works. Run pip debug --verbose and you'll see everything your current version supports - you'll see all older macOS versions listed there.

@henryiii
Copy link
Member

Looks like 3.11 was missed here:

- os: macos-latest
py: cp38
arch: universal2
- os: macos-latest
py: cp39
arch: universal2
- os: macos-latest
py: cp310
arch: universal2

@HDembinski
Copy link
Member

Ok, so all I have to do is to generate the missing wheel for Python3.11 then.

@HDembinski
Copy link
Member

Release 2.18.0 contains a Python3.11 wheel for macos universal2

@HDembinski
Copy link
Member

If there are still issues, ping me and reopen.

@nega0
Copy link
Author

nega0 commented Dec 14, 2022

Confirmed availability w/ python 3.11 on Ventura. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants