Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conversion Hist -> ROOT #262

Open
slehti opened this issue Jul 16, 2021 · 2 comments
Open

conversion Hist -> ROOT #262

slehti opened this issue Jul 16, 2021 · 2 comments
Assignees
@henryiii @LovelyBuggies
Labels
enhancement New feature or request

Comments

@slehti
Copy link

slehti commented Jul 16, 2021

In coffea, there is support for converting coffea histograms to root histograms by uproot3 for 1-dimensional histograms only.

I'm using in my analysis lots of 2-dimensional histograms, so i wrote conversions

  • counter (processor.defaultdict_accumulator) -> ROOT.TH1D
  • Hist (1D) -> ROOT.TH1D
  • Hist (2D) -> ROOT.TH2D

The right place for these is in hist. I have working code which i could supply as a PR once i get a go-ahead.
Cheers,
Sami Lehti (sami.lehti@cern.ch)
@slehti slehti added the enhancement New feature or request label Jul 16, 2021
@henryiii
Copy link
Member

That would be great, a starter PR would be appreciated :)

@slehti
Copy link
Author

slehti commented Jul 19, 2021

A new file in hist/src/hist?

@henryiii henryiii mentioned this issue Aug 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henryiii henryiii

@LovelyBuggies LovelyBuggies

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@henryiii @slehti @LovelyBuggies