Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible n+1 query in Admin::OralHistoryRequestsController#index #2852

Open
eddierubeiz opened this issue Jan 17, 2025 · 2 comments
Open

Possible n+1 query in Admin::OralHistoryRequestsController#index #2852

eddierubeiz opened this issue Jan 17, 2025 · 2 comments
Labels
infrastructure related to heroku, AWS, etc deploy/operational infrastructure maintenance/performance not new features or bugfixes, but keeping/improving the app running well oral histories

Comments

@eddierubeiz
Copy link
Contributor

If I'm reading the analysis from Scout APM correctly, we could dramatically speed up the /admin/oral_history_requests page by loading more associations in the index method of the admin pages' list of oral histories.

Not urgent, but a good idea to look into this.
@eddierubeiz eddierubeiz added infrastructure related to heroku, AWS, etc deploy/operational infrastructure maintenance/performance not new features or bugfixes, but keeping/improving the app running well oral histories labels Jan 17, 2025
@jrochkind
Copy link
Contributor

Sweet, good catch! We should def investigate

@jrochkind
Copy link
Contributor

Can also use Rails strict_loading method so that we'll actually get an exception raised if we try to load somethign we should have include eager loaded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure related to heroku, AWS, etc deploy/operational infrastructure maintenance/performance not new features or bugfixes, but keeping/improving the app running well oral histories
Projects
Digital Collections Team
Status: Inbox
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eddierubeiz @jrochkind