Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter notebook does not display a html table #134

Open
RoelofWobben opened this issue Feb 9, 2025 · 7 comments
Open

Jupyter notebook does not display a html table #134

RoelofWobben opened this issue Feb 9, 2025 · 7 comments

Comments

@RoelofWobben
Copy link

Hello,

IM following this page of the noj book : https://scicloj.github.io/noj/noj_book.tablecloth_table_processing.html
But as soon as I try to display the html table I do not see it on a jupyter notebook.

See this screenshot:

Image

@daslu
Copy link
Member

daslu commented Feb 9, 2025

Thanks!

@behrica
Copy link
Member

behrica commented Feb 10, 2025

@daslu
I see it document as "expected to work":
"A dataset can be also treated as a table input."

So I opended bug report here:
clojupyter/clojupyter#215

@behrica
Copy link
Member

behrica commented Feb 10, 2025

@RoelofWobben
Maybe use kind/dataset in the meanwhile ?

https://scicloj.github.io/kindly-noted/kinds.html#datasets

@behrica
Copy link
Member

behrica commented Feb 10, 2025

@daslu
several other "table" variants are not working in Clojupyter neither.

Image

I have them already on my to do lists.
Partialy it is due to "kindly-render" not handling all variants:

scicloj/kindly-render#30
scicloj/kindly-render#29

I have locally fixed this concrete issue with a workarround, so not using kindly-render when the value is dataset

This is as well related to the question of "recursive table rendering". (which a dataset does not support, correct ?)

@behrica
Copy link
Member

behrica commented Feb 10, 2025

We have "table support" marked as "yellow" in our compatibility table:
https://scicloj.github.io/kindly-noted/kind_compatibility.html

But I agree, not "render at all" is a bigger problem, then "render differently" (which all other yellows mean)

I am not sure, if I can/should address the not working case of "(kind/table (take 5 people-as-maps))" as "an exception in clojupyter".

For the recursive rendering I rely on "kindly-render" and I don't want to "take/copy that into clojupyter".

To me we need to fix the 2 above issue in kindly-render to fix "(kind/table (take 5 people-as-maps))"

@behrica
Copy link
Member

behrica commented Feb 10, 2025

@RoelofWobben
As you can see here: https://scicloj.github.io/kindly-noted/kind_compatibility.html

we are aware that the kindly compatibility of clojupyter is not yet 100 %.

"Clay" is 100 % compatible, in fact the Noj book:

https://scicloj.github.io/noj/noj_book.tablecloth_table_processing.html

is rendered using Clay. (https://github.com/scicloj/clay)

We are of course aiming for 100 % compatibility, and welcome all reports of differences between Clay and clojupyter.
In case you find others, please report them here:
https://github.com/clojupyter/clojupyter/issues

@daslu
Copy link
Member

daslu commented Feb 10, 2025

Thanks for these clarifying comments, @behrica.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants