Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FQDN object with - is considered as IP range #2

Closed
rijnier opened this issue Jan 8, 2025 · 0 comments · Fixed by #3
Closed

FQDN object with - is considered as IP range #2

rijnier opened this issue Jan 8, 2025 · 0 comments · Fixed by #3
Assignees
@rijnier

Comments

@rijnier
Copy link
Collaborator

rijnier commented Jan 8, 2025

Because of the ordering in kindFromValue a FQDN object with a - gets evaluated by this line first:

go-ciscoasa/ciscoasa/ciscoasa.go

Line 225 in 098798c

if strings.Contains(value, "-") {

before it reaches the FQDN check:

go-ciscoasa/ciscoasa/ciscoasa.go

Line 267 in 098798c

if govalidator.IsDNSName(value) {

@rijnier rijnier self-assigned this Jan 8, 2025
@rijnier rijnier linked a pull request Jan 30, 2025 that will close this issue
fix: prevent FQDN with - to be detected as IP range #3
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rijnier rijnier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevent FQDN with - to be detected as IP range schubergphilis/go-ciscoasa
1 participant
@rijnier