feat!: use generics for new progressbar creation #132
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to allow either int or int64 when calling various 'New' methods to create new progressbar instances.
This is a breaking change as it requires Go v1.18 to make use of generics. May be worth stating this in the README above the installation title on v4 release.
## Requires Progressbar V4 requires Go version v1.18 or later.
Note: Can't make methods generics (i.e. those bound to structs,
ChangeMax
,ChangeMax64
etc) due to limitations in current generics implementation with Go.Resolves #129