Switch to stream.Writable #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore streaming flexibility
|
Sounds reasonable. Thank you for your contribution. I will release a new version this evening. |
|
Great, thanks! |
|
SwissQRBill v2.2.0 containing your changes is now published on npm. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched from fs.WriteStream to stream.Writable in order to provide more streaming flexibility.
The current version expects fs.WriteStream which limits writing to files. Since fs.WriteStream is based on stream.Writable, and there's no specific functionality needed from fs.WriteStream, it's beneficial to switch to stream.Writable. This way, you can use any writable stream to write the generated PDF.
Cheers
Gion