Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File paths next to the translation line. #257

Closed
feyyazesat opened this issue Sep 8, 2015 · 2 comments
Closed

File paths next to the translation line. #257

feyyazesat opened this issue Sep 8, 2015 · 2 comments

Comments

@feyyazesat
Copy link

Hi, sorry I couldn't create a pull request about that but I can give some info here.
I added below codes;

                $sources = $v->getSources();
                $fileLocatorComment = null;
                foreach ($sources as $source) {
                    if (is_null($fileLocatorComment)) {
                        $fileLocatorComment = $source->getPath() . ' (' . $source->getLine() . ", ";
                    } else {
                        $fileLocatorComment .= $source->getLine() . ", ";
                    }

                }
                $fileLocatorComment = rtrim($fileLocatorComment, ', ') . ')';
                $this->writer->write('   # ' . $fileLocatorComment);

to TranslationBundle/Translation/Dumper/YamlDumper.php after below lines.

                if ($v->isNew()) {
                    $this->writer->write('   # FIXME');
                }

It produces attached images, and it would be really nice feature to see which translation key/value is in which file.
2015-09-08-034310_1366x768_scrot

@feyyazesat
Copy link
Author

Sorry I have deadline concern that because I cannot focus to improve feature and open a pull request if anybody has enough time to do it. Could be a really cool feature.
There is also Xliff and php dumper, you have to implement the code.

attached image could be give more implementation details.
2015-09-08-034910_1366x768_scrot

@Nyholm
Copy link
Collaborator

Nyholm commented Aug 5, 2016

I'll close this as a won't fix for the following reasons:

  • Best practice says you should use Xliff where you do have this feature
  • You can use the file paths in a good way
  • You have this functionality in the WebUI.
  • There does not seam to be any interest in this feature

@Nyholm Nyholm closed this as completed Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants