Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove dependency on the DI Bundle #23

Closed
tarjei opened this issue Jan 30, 2012 · 3 comments
Closed

Please remove dependency on the DI Bundle #23

tarjei opened this issue Jan 30, 2012 · 3 comments

Comments

@tarjei
Copy link
Contributor

tarjei commented Jan 30, 2012

Hi,

The DI bundle seems nice enough, but it adds way more extra config than needed for this bundle to work. It would be great if you removed the dependency so that it became easier to install this bundle.

Regards,
Tarjei

@schmittjoh
Copy link
Owner

Actually, it's not necessary for this bundle only for the default controller of the webinterface.

You could add constructor injection to the controller though and configure it as a service. This is a bit more work though, and requires a bit of extra code which I don't want to maintain.

If you have other ideas for making the installation process easier, I would look forward to it. I think once composer is a bit more widespread it should be fairly easy already including with this optional dependency.

@tarjei
Copy link
Contributor Author

tarjei commented Jan 30, 2012

I actually installed the bundle to get the web interface :)

Anyhow the interface didn't quite fit as it required that I had the translations in the app/Applications/translations dir (I got mine in my bundles) so I'll continue searching for another way to do things.

Thanks for the different JMS bundles though :)

@schmittjoh
Copy link
Owner

np, you're welcome :)

btw, it should be possible to have the files in bundles. You just need to configure the directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants