Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Editing? #10

Closed
nurikabe opened this issue Nov 29, 2011 · 5 comments
Closed

Inline Editing? #10

nurikabe opened this issue Nov 29, 2011 · 5 comments

Comments

@nurikabe
Copy link
Contributor

This bundle is a godsend.

Any plans to implement inline editing via https://github.com/tuupola/jquery_jeditable or similar? This would drastically simplify the translation process.

@stof
Copy link
Contributor

stof commented Nov 29, 2011

@schmittjoh
Copy link
Owner

It is not planned, but patches are welcome.

One thing to note about inline editing is that it is very fragile (e.g. translations for buttons, and links). A better approach IMO would be to just collect all translations used on the current page, and then allow them to be edited (but not inline).

@nurikabe
Copy link
Contributor Author

nurikabe commented Dec 2, 2011

Good point. Either all translations for the current page or a popup for each item in the DOM perhaps.

BTW, how will JMSTranslationBundle change with the new Extraction functionality coming out in 2.1? (Sorry to turn this into a discussion.)

@stof
Copy link
Contributor

stof commented Dec 2, 2011

@nurikabe this bundle is already compatible with the new features but provide more advanced features too. So people wanting just the basic extraction will be able to use the core implementation, and people wanting more powerful stuff will use the bundle

@nurikabe
Copy link
Contributor Author

nurikabe commented Dec 2, 2011

Awesome, thanks. If nobody beats me to it, I'll look into "dynamic page editing" from late December I think.

@nurikabe nurikabe closed this as completed Dec 2, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants