-
-
Notifications
You must be signed in to change notification settings - Fork 332
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Is there any reasoning behind using "display": "minimal-ui"
in the manifest?
#254
Comments
Thanks for the explanation! But that's unfortunate. As for me I would rather get rid of QR codes completely. It's not like it's much easier to use camera than just typing in 5-6 digits. I feel like it's even harder to be honest. Still very nice piece of software. Keep it up! |
That occured to me too, but I thought it went against the idea of simplicity that you talk about in FAQ.
To be honest I don't know. Here are my thoughts:
I use pairdrop.net. I guess that's not a bad idea, especially if there's an explanation of what it will change. |
Thanks for your thoughts!
Yes true, it’s not easy to find the right balance and keep the main user flow straight forward. In the end, an in-app QR-code scanner would only be an improvement for the PWA and for (future) apps. So it could be a compromise to show the camera button only when these states are recognized. (We could easily check that the PWA is running standalone and an app could use an API call.) So it would never be shown to users that use the browser or on Desktop browsers (which would not make much sense) but only from the app.
Good points. A tab bar would be on the bottom of everything else, wouldn’t it? I’m resistent to use up even more vertical space as the most space should be reserved for the peers.. My current favorite would be on the top left corner analogous to the about PairDrop (x) button. Any thoughts?
Sure there would be a reference in the docs |
Didn't quite get it. Why wouldn't it make sense? Because of tablets and laptops with rear cameras? |
Yeah, on the bottom like in IOS apps. Maybe you're right.
I guess that's the best solution if you don't feel like adding a tab bar. |
I don’t think anyone would scan a QR code via the front camera of a laptop so I would hide the button on Desktop. I’m not sure about Tablets. I guess the best approach would be to only show the button if display is standalone and device is Android / iOS. It’s a small feature though that would add complexity. I will put this into ‚to be decided‘ for now. |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
I feel like I've seen similar issues but couldn't find them so I opened a new one.
Problem
If I install PairDrop as a PWA, because of
"display": "minimal-ui"
in manifest.json it opens a new tab in Safari instead of opening its own window. Because of this behavior, there is no point in using PairDrop as a PWA (at least for me).Possible solution
Other PWA apps I've installed use
"display": "standalone"
which solves this issue.Question
Is there any particular reason for using
"minimal-ui"
instead of"standalone"
?Smartphone
PairDrop/public/manifest.json
Line 31 in 3fa0873
The text was updated successfully, but these errors were encountered: