Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Is there any reasoning behind using "display": "minimal-ui" in the manifest? #254

Closed
aivarovskiy opened this issue Jan 29, 2024 · 4 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@aivarovskiy
Copy link

I feel like I've seen similar issues but couldn't find them so I opened a new one.

Problem
If I install PairDrop as a PWA, because of "display": "minimal-ui" in manifest.json it opens a new tab in Safari instead of opening its own window. Because of this behavior, there is no point in using PairDrop as a PWA (at least for me).

Possible solution
Other PWA apps I've installed use "display": "standalone" which solves this issue.

Question
Is there any particular reason for using "minimal-ui" instead of "standalone"?

Smartphone

  • Device: iPhone X
  • OS: IOS 16.1.2
  • Browser: Safari

"display": "minimal-ui",

@schlagmichdoch schlagmichdoch added the question Further information is requested label Jan 29, 2024
@aivarovskiy
Copy link
Author

Thanks for the explanation!

But that's unfortunate. As for me I would rather get rid of QR codes completely. It's not like it's much easier to use camera than just typing in 5-6 digits. I feel like it's even harder to be honest.

Still very nice piece of software. Keep it up!

@aivarovskiy
Copy link
Author

There could also be the possibility to add a QR code scanner to PairDrop itself. This would make it possible to use QR codes from inside the PWA or an app (like Snapdrop & PairDrop for Android).

That occured to me too, but I thought it went against the idea of simplicity that you talk about in FAQ.

I’m not sure where to put a camera button though in order to not clutter the UI. Any thoughts?

To be honest I don't know. Here are my thoughts:

  • Adding another icon at the top feels wrong. I think there are already almost too many icons.
  • Making the camera accessible only from pairing/room dialogs adds extra step and makes it more confusing to find.
  • Tab bar with a separate tab for the camera sounds like a good option, but that, again, goes against the idea of simplicity. However, in return it'll help clean up the UI and improve the UX.

Also, do you host PairDrop yourself or do you use pairdrop.net? I guess we could make the manifest variable "display": "standalone" editable via an environment variable.

I use pairdrop.net. I guess that's not a bad idea, especially if there's an explanation of what it will change.

@schlagmichdoch
Copy link
Owner

Thanks for your thoughts!

That occured to me too, but I thought it went against the idea of simplicity that you talk about in FAQ.

Yes true, it’s not easy to find the right balance and keep the main user flow straight forward.

In the end, an in-app QR-code scanner would only be an improvement for the PWA and for (future) apps. So it could be a compromise to show the camera button only when these states are recognized. (We could easily check that the PWA is running standalone and an app could use an API call.)

So it would never be shown to users that use the browser or on Desktop browsers (which would not make much sense) but only from the app.

  • Adding another icon at the top feels wrong. I think there are already almost too many icons.
  • Making the camera accessible only from pairing/room dialogs adds extra step and makes it more confusing to find.
  • Tab bar with a separate tab for the camera sounds like a good option, but that, again, goes against the idea of simplicity. However, in return it'll help clean up the UI and improve the UX.

Good points. A tab bar would be on the bottom of everything else, wouldn’t it? I’m resistent to use up even more vertical space as the most space should be reserved for the peers..

My current favorite would be on the top left corner analogous to the about PairDrop (x) button. Any thoughts?

I guess that's not a bad idea, especially if there's an explanation of what it will change.

Sure there would be a reference in the docs

@schlagmichdoch schlagmichdoch added the enhancement New feature or request label Feb 1, 2024
@aivarovskiy
Copy link
Author

So it would never be shown to users that use the browser or on Desktop browsers (which would not make much sense) but only from the app.

Didn't quite get it. Why wouldn't it make sense? Because of tablets and laptops with rear cameras?

@aivarovskiy
Copy link
Author

Good points. A tab bar would be on the bottom of everything else, wouldn’t it? I’m resistent to use up even more vertical space as the most space should be reserved for the peers..

Yeah, on the bottom like in IOS apps. Maybe you're right.

My current favorite would be on the top left corner analogous to the about PairDrop (x) button. Any thoughts?

I guess that's the best solution if you don't feel like adding a tab bar.

@schlagmichdoch
Copy link
Owner

Didn't quite get it. Why wouldn't it make sense? Because of tablets and laptops with rear cameras?

I don’t think anyone would scan a QR code via the front camera of a laptop so I would hide the button on Desktop. I’m not sure about Tablets.

I guess the best approach would be to only show the button if display is standalone and device is Android / iOS.

It’s a small feature though that would add complexity. I will put this into ‚to be decided‘ for now.

Repository owner locked and limited conversation to collaborators Feb 15, 2024
@schlagmichdoch schlagmichdoch converted this issue into discussion #273 Feb 15, 2024
Repository owner deleted a comment from schlagmichdoch Feb 17, 2024
Repository owner deleted a comment from schlagmichdoch Feb 17, 2024
Repository owner deleted a comment from schlagmichdoch Feb 17, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants