Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix best track forcing issue due to dependency update #68

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Fix best track forcing issue due to dependency update #68

merged 1 commit into from
Apr 21, 2023

Conversation

SorooshMani-NOAA
Copy link
Contributor

Fixes #64

@SorooshMani-NOAA
Copy link
Contributor Author

@cuill I added generic *args and **kwargs for the constructor so that it doesn't conflict with unused arguments from upstream. I also added a new test to check if reading from file (the issue in #64) works fine.

@cuill cuill merged commit 96aedc3 into schism-dev:main Apr 21, 2023
@cuill
Copy link
Member

cuill commented Apr 21, 2023

@SorooshMani-NOAA Thanks.

@SorooshMani-NOAA SorooshMani-NOAA deleted the bugfix/besttrack branch April 24, 2023 11:49
mansurjisan pushed a commit to mansurjisan/pyschism that referenced this pull request Aug 22, 2024
@cuill
Merge pull request schism-dev#68 from SorooshMani-NOAA/bugfix/besttrack
b046179 
Fix best track forcing issue due to dependency update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BestTrackForcing breaks due to update in StormEvents
2 participants
@SorooshMani-NOAA @cuill