Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BestTrackForcing breaks due to update in StormEvents #64

Closed
SorooshMani-NOAA opened this issue Apr 13, 2023 · 2 comments · Fixed by #68
Closed

BestTrackForcing breaks due to update in StormEvents #64

SorooshMani-NOAA opened this issue Apr 13, 2023 · 2 comments · Fixed by #68
Assignees
@SorooshMani-NOAA

Comments

@SorooshMani-NOAA
Copy link
Contributor

BestTrackForcing class inherits VortexTrack. There has been a recent change to the latter (oceanmodeling/StormEvents#74) which breaks the BestTrackForcing class:

  File ".../setup_model.py", line 96, in setup_schism_model
    atmospheric = BestTrackForcing.from_nhc_bdeck(nhc_bdeck=nhc_track_file)
  File ".../pyschism/forcing/nws/best_track.py", line 69, in from_nhc_bdeck
    return cls.from_file(path=nhc_bdeck, start_date=start_date, end_date=end_date)
  File ".../stormevents/nhc/track.py", line 176, in from_file
    return cls(
TypeError: __init__() got an unexpected keyword argument 'file_deck'
@SorooshMani-NOAA SorooshMani-NOAA mentioned this issue Apr 13, 2023
Open
@cuill
Copy link
Member

cuill commented Apr 17, 2023

@SorooshMani-NOAA Can you take care of this issue? Thanks.

@SorooshMani-NOAA
Copy link
Contributor Author

Sure, I'll work on this

@SorooshMani-NOAA SorooshMani-NOAA mentioned this issue Apr 21, 2023
Merged
@cuill cuill closed this as completed in #68 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SorooshMani-NOAA SorooshMani-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix best track forcing issue due to dependency update SorooshMani-NOAA/pyschism
2 participants
@cuill @SorooshMani-NOAA