Skip to content
This repository has been archived by the owner on Nov 24, 2018. It is now read-only.

Make timeout of wait() customizable #53

Closed
Junkern opened this issue Jul 27, 2017 · 2 comments
Closed

Make timeout of wait() customizable #53

Junkern opened this issue Jul 27, 2017 · 2 comments

Comments

@Junkern
Copy link

Junkern commented Jul 27, 2017

I have been playing around with chromeless and I noticed, that there is a timeout for the wait() function (https://github.com/graphcool/chromeless/blob/master/src/api.ts#L21).

Would be great to be able to customize that. Not sure if it's better via an options object directly passed to the wait() function or via a global config object passed to the new Chromeless().

I can also make a PR for the chosen option.

@schickling
Copy link
Owner

This is actually already possible, just seems like we haven't documented it yet (see #54).

You can see here how it works

@Junkern
Copy link
Author

Junkern commented Jul 27, 2017

Yeah, I noticed that aswell 2 minutes after creating the issue^^

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants