Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounding grid updates on properties panel change of scale #234

Open
kephale opened this issue Oct 29, 2019 · 7 comments
Open

Bounding grid updates on properties panel change of scale #234

kephale opened this issue Oct 29, 2019 · 7 comments
Labels
1.0.0 1.0.0 release verified Bugs or issues that have been verified
Milestone

Comments

@kephale
Copy link
Member

kephale commented Oct 29, 2019

Check that the bounding box is regenerated when an object is rescaled

@kephale
Copy link
Member Author

kephale commented Oct 29, 2019

This is probably a scenery thing @skalarproduktraum

@kephale
Copy link
Member Author

kephale commented Oct 29, 2019

The problem is that generateBoundingBox in scenery doesn't use scale factors

@kephale kephale added needs-verification This issue needs additional information or confirmation 1.0.0 1.0.0 release labels Jun 10, 2023
@kephale
Copy link
Member Author

kephale commented Jun 13, 2023

This is still a problem but it manifests differently.

To reproduce:

  1. Add an object like a sphere
  2. Toggle bounding box of the sphere
  3. Set the scale of the sphere

The bounding box adjusts for the scale, but the font and legend does too. See:

image

@kephale kephale added verified Bugs or issues that have been verified and removed needs-verification This issue needs additional information or confirmation labels Jun 13, 2023
@kephale
Copy link
Member Author

kephale commented Jun 13, 2023

@skalarproduktraum @moreApi I suspect this is the kind of thing that we want to solve in scenery.

@moreApi
Copy link
Member

moreApi commented Jun 13, 2023

I think we should make the text "scale resistant". At least for non isomorph scalings.

@kephale
Copy link
Member Author

kephale commented Jun 13, 2023

Yeah, in this case I'd hope for the text to say isotropic, and adjust size with the smallest change in scale for the plane the text is rendered in.

It might be worthwhile to do that for the tic marks on the bounding box, because they won't be symmetric across the whole BB this way.

@kephale
Copy link
Member Author

kephale commented Jun 14, 2023

@skalarproduktraum should we make a corresponding issue in scenery?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0 1.0.0 release verified Bugs or issues that have been verified
Projects
None yet
Development

No branches or pull requests

2 participants