Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinate system #51

Closed
arnodelorme opened this issue Jan 5, 2021 · 8 comments
Closed

Coordinate system #51

arnodelorme opened this issue Jan 5, 2021 · 8 comments

Comments

@arnodelorme
Copy link
Collaborator

We export in the ARS system, but BIDS only compatible with the RAS system now (see also this post below)

bids-standard/bids-specification#701

Once the issue is resolved:

  • We might have to export to RAS (rotate channels)
  • Rotate them back to ARS when we import BIDS data
@dungscout96
Copy link
Contributor

For now we circumvent it by putting "Other" as EEGCoordinateSystem and "EEGLAB" in EEGCoordinateSystemDescription. Once EEGLAB is accepted we'll change EEGCoordinateSystem to "EEGLAB".
Implemented in EEGCoordinateSystem

@BjoernHoltze
Copy link

Before and after exporting my dataset into BIDS, in EEGLAB the electrodes were represented according to the ALS system but not according to the ARS system and the units were not given in mm since the spherical radius was 1. When I checked the sample data from EEGLAB 2020_0, the units seemed to be in mm as the spherical radius was about 88, but the electrodes were also represented according to the ALS. Thus, I have two questions:

  1. Is left and right switched in EEGLAB according to radiological terminology?
  2. Are you intending to integrate the option "normalized" for EEGCoordinateUnits if the spherical radius is equal to 1?

@arnodelorme arnodelorme changed the title RAS coordinate system Coordinate system Jan 19, 2021
@arnodelorme
Copy link
Collaborator Author

To do:

  • Clement to create web page describing our coordinate system
  • Arno to send it to Stefan
  • bids_export to set the coordinate system to EEGLAB
  • bids_import to rotate Captrack system when BIDS data is imported

@sappelhoff
Copy link

Any news on this @arnodelorme @cll008? The web page really doesn't have to be big or shiny --> a couple of sentences describing the coordinate system will suffice!

Perhaps in the meantime these lines:

https://github.com/sccn/bids-matlab-tools/blob/801dacb7ea6ef262009150dbe7ba6873c446c480/bids_export.m#L951-L952

Can be changed so that it says: "'EEGLAB': ARS with origin exactly between LPA and RPA; X=Anterior Y=Right Z=Superior"

That'd be more helpful than just "EEGLAB" WDYT?

@cll008
Copy link
Contributor

cll008 commented Feb 12, 2021

Thanks for following up @sappelhoff . I wrote a draft of a page but Arno and I are checking in with Scott on some things.

@sappelhoff
Copy link

@arnodelorme @cll008 have you seen my comment in bids-standard/bids-specification#701 (comment) ?

We basically just need a documentation page for the EEGLAB coordinate system that we could link to ... then we can make a PR to allow that keyword in both specification and validator.

@cll008
Copy link
Contributor

cll008 commented Apr 13, 2021

Thanks for the follow up @sappelhoff. Arno just made the webpage live. The coordinate descriptions are correct but we are making some more edits to the rest of the text.

@sappelhoff
Copy link

Thanks for the follow up @sappelhoff. Arno just made the webpage live. The coordinate descriptions are correct but we are making some more edits to the rest of the text.

That's looking good! I'll prepare two PRs (one to the BIDS spec, one to the BIDS validator) and will tag you in it so that you can review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants