Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instance.ListImages method do not returns public images by default #206

Closed
QuentinBrosse opened this issue Oct 10, 2019 · 2 comments
Closed
Labels
bug Something isn't working instance Instance issues, bugs and feature requests
Milestone

Comments

@QuentinBrosse
Copy link
Contributor

The SDK uses the default organization ID to fill the organization query param and set the public query param to true of the /instance/v1/zones/fr-par-1/images endpoint.

GET /instance/v1/zones/fr-par-1/images?organization={ORG_ID}&public=true

Therefore, the API returns all the public images from the user default organization. The default behavior that we want for this method is to return all the public Scaleway images.

We need to make this call by default:

GET /instance/v1/zones/fr-par-1/images
@QuentinBrosse
Copy link
Contributor Author

👋 @tboerger

@QuentinBrosse QuentinBrosse added the bug Something isn't working label Oct 10, 2019
@QuentinBrosse QuentinBrosse added this to the v1.0.0-beta.4 milestone Oct 10, 2019
This was referenced Oct 11, 2019
@QuentinBrosse
Copy link
Contributor Author

Fixed with #208 #209 and #216.

Thanks again for repporting this issue @tboerger ! 🙏

@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working instance Instance issues, bugs and feature requests
Projects
None yet
Development

No branches or pull requests

2 participants