fix(shell): crash when completing map of object (#2845)

Codelax · web-flow · commit ac91828dfcd4 · 2023-03-06T15:29:31.000Z
diff --git a/internal/core/shell.go b/internal/core/shell.go
@@ -158,7 +158,7 @@ func sortOptions(meta *meta, args []string, toSuggest string, suggestions []stri
 	}
 
 	sort.Slice(argSpecs, func(i, j int) bool {
-		if argSpecs[i].Arg.Required != argSpecs[j].Arg.Required {
+		if argSpecs[i].Arg != nil && argSpecs[j].Arg != nil && argSpecs[i].Arg.Required != argSpecs[j].Arg.Required {
 			return argSpecs[i].Arg.Required
 		}
 		return argSpecs[i].Text < argSpecs[j].Text

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ func sortOptions(meta *meta, args []string, toSuggest string, suggestions []stri`
`158`	`158`	`}`
`159`	`159`
`160`	`160`	`sort.Slice(argSpecs, func(i, j int) bool {`
`161`		`- if argSpecs[i].Arg.Required != argSpecs[j].Arg.Required {`
	`161`	`+ if argSpecs[i].Arg != nil && argSpecs[j].Arg != nil && argSpecs[i].Arg.Required != argSpecs[j].Arg.Required {`
`162`	`162`	`return argSpecs[i].Arg.Required`
`163`	`163`	`}`
`164`	`164`	`return argSpecs[i].Text < argSpecs[j].Text`