Revert "feat(secret-manager): add endpoints for using name to retrieve secrets" (#2801)

scaleway-bot · web-flow · commit 9ad6f81245ef · 2023-02-28T10:18:45.000Z
diff --git a/cmd/scw/testdata/test-all-usage-secret-secret-get-usage.golden b/cmd/scw/testdata/test-all-usage-secret-secret-get-usage.golden
@@ -7,7 +7,6 @@ USAGE:
 
 ARGS:
   secret-id         ID of the Secret
-  [secret-name]     Name of the Secret (alternative to secret_id)
   [region=fr-par]   Region to target. If none is passed will use default region from the config (fr-par)
 
 FLAGS:
diff --git a/cmd/scw/testdata/test-all-usage-secret-secret-list-usage.golden b/cmd/scw/testdata/test-all-usage-secret-secret-list-usage.golden
@@ -8,7 +8,6 @@ USAGE:
 ARGS:
   [project-id]        ID of a project to filter on (optional)
   [tags.{index}]      List of tags to filter on (optional)
-  [name]              Name of the secrets (optional)
   [order-by]           (name_asc | name_desc | created_at_asc | created_at_desc | updated_at_asc | updated_at_desc)
   [organization-id]   ID of an organization to filter on (optional)
   [region=fr-par]     Region to target. If none is passed will use default region from the config (fr-par | all)
diff --git a/cmd/scw/testdata/test-all-usage-secret-version-access-usage.golden b/cmd/scw/testdata/test-all-usage-secret-version-access-usage.golden
@@ -7,8 +7,7 @@ USAGE:
 
 ARGS:
   secret-id         ID of the Secret
-  [secret-name]     Name of the Secret (alternative to secret_id)
-  revision          Revision of the SecretVersion (may be a number, "latest" or "latest_enabled")
+  revision          Revision of the SecretVersion (may be a number or "latest")
   [region=fr-par]   Region to target. If none is passed will use default region from the config (fr-par)
 
 FLAGS:
diff --git a/cmd/scw/testdata/test-all-usage-secret-version-get-usage.golden b/cmd/scw/testdata/test-all-usage-secret-version-get-usage.golden
@@ -7,7 +7,6 @@ USAGE:
 
 ARGS:
   secret-id         ID of the Secret
-  [secret-name]     Name of the Secret (alternative to secret_id)
   revision          Revision of the SecretVersion (may be a number or "latest")
   [region=fr-par]   Region to target. If none is passed will use default region from the config (fr-par)
 
diff --git a/cmd/scw/testdata/test-all-usage-secret-version-list-usage.golden b/cmd/scw/testdata/test-all-usage-secret-version-list-usage.golden
@@ -7,7 +7,6 @@ USAGE:
 
 ARGS:
   secret-id          ID of the Secret
-  [secret-name]      Name of the Secret (alternative to secret_id)
   [status.{index}]   Filter results by status (unknown | enabled | disabled | destroyed)
   [region=fr-par]    Region to target. If none is passed will use default region from the config (fr-par | all)
 
diff --git a/docs/commands/secret.md b/docs/commands/secret.md
@@ -104,7 +104,6 @@ scw secret secret get [arg=value ...]
 | Name |   | Description |
 |------|---|-------------|
 | secret-id | Required | ID of the Secret |
-| secret-name |  | Name of the Secret (alternative to secret_id) |
 | region | Default: `fr-par`<br />One of: `fr-par` | Region to target. If none is passed will use default region from the config |
 
 
@@ -126,7 +125,6 @@ scw secret secret list [arg=value ...]
 |------|---|-------------|
 | project-id |  | ID of a project to filter on (optional) |
 | tags.{index} |  | List of tags to filter on (optional) |
-| name |  | Name of the secrets (optional) |
 | order-by | One of: `name_asc`, `name_desc`, `created_at_asc`, `created_at_desc`, `updated_at_asc`, `updated_at_desc` |  |
 | organization-id |  | ID of an organization to filter on (optional) |
 | region | Default: `fr-par`<br />One of: `fr-par`, `all` | Region to target. If none is passed will use default region from the config |
@@ -178,8 +176,7 @@ scw secret version access [arg=value ...]
 | Name |   | Description |
 |------|---|-------------|
 | secret-id | Required | ID of the Secret |
-| secret-name |  | Name of the Secret (alternative to secret_id) |
-| revision | Required | Revision of the SecretVersion (may be a number, "latest" or "latest_enabled") |
+| revision | Required | Revision of the SecretVersion (may be a number or "latest") |
 | region | Default: `fr-par`<br />One of: `fr-par` | Region to target. If none is passed will use default region from the config |
 
 
@@ -295,7 +292,6 @@ scw secret version get [arg=value ...]
 | Name |   | Description |
 |------|---|-------------|
 | secret-id | Required | ID of the Secret |
-| secret-name |  | Name of the Secret (alternative to secret_id) |
 | revision | Required | Revision of the SecretVersion (may be a number or "latest") |
 | region | Default: `fr-par`<br />One of: `fr-par` | Region to target. If none is passed will use default region from the config |
 
@@ -317,7 +313,6 @@ scw secret version list [arg=value ...]
 | Name |   | Description |
 |------|---|-------------|
 | secret-id | Required | ID of the Secret |
-| secret-name |  | Name of the Secret (alternative to secret_id) |
 | status.{index} | One of: `unknown`, `enabled`, `disabled`, `destroyed` | Filter results by status |
 | region | Default: `fr-par`<br />One of: `fr-par`, `all` | Region to target. If none is passed will use default region from the config |
 
diff --git a/internal/namespaces/secret/v1alpha1/secret_cli.go b/internal/namespaces/secret/v1alpha1/secret_cli.go
@@ -133,13 +133,6 @@ func secretSecretGet() *core.Command {
 				Deprecated: false,
 				Positional: false,
 			},
-			{
-				Name:       "secret-name",
-				Short:      `Name of the Secret (alternative to secret_id)`,
-				Required:   false,
-				Deprecated: false,
-				Positional: false,
-			},
 			core.RegionArgSpec(scw.RegionFrPar),
 		},
 		Run: func(ctx context.Context, args interface{}) (i interface{}, e error) {
@@ -228,13 +221,6 @@ func secretSecretList() *core.Command {
 				Deprecated: false,
 				Positional: false,
 			},
-			{
-				Name:       "name",
-				Short:      `Name of the secrets (optional)`,
-				Required:   false,
-				Deprecated: false,
-				Positional: false,
-			},
 			{
 				Name:       "order-by",
 				Required:   false,
@@ -391,13 +377,6 @@ func secretVersionGet() *core.Command {
 				Deprecated: false,
 				Positional: false,
 			},
-			{
-				Name:       "secret-name",
-				Short:      `Name of the Secret (alternative to secret_id)`,
-				Required:   false,
-				Deprecated: false,
-				Positional: false,
-			},
 			{
 				Name:       "revision",
 				Short:      `Revision of the SecretVersion (may be a number or "latest")`,
@@ -479,13 +458,6 @@ func secretVersionList() *core.Command {
 				Deprecated: false,
 				Positional: false,
 			},
-			{
-				Name:       "secret-name",
-				Short:      `Name of the Secret (alternative to secret_id)`,
-				Required:   false,
-				Deprecated: false,
-				Positional: false,
-			},
 			{
 				Name:       "status.{index}",
 				Short:      `Filter results by status`,
@@ -667,16 +639,9 @@ func secretVersionAccess() *core.Command {
 				Deprecated: false,
 				Positional: false,
 			},
-			{
-				Name:       "secret-name",
-				Short:      `Name of the Secret (alternative to secret_id)`,
-				Required:   false,
-				Deprecated: false,
-				Positional: false,
-			},
 			{
 				Name:       "revision",
-				Short:      `Revision of the SecretVersion (may be a number, "latest" or "latest_enabled")`,
+				Short:      `Revision of the SecretVersion (may be a number or "latest")`,
 				Required:   true,
 				Deprecated: false,
 				Positional: false,
