fix(instance): delete server with multiple IPs (#4223)

Author: Codelax

internal/namespaces/instance/v1/custom_server.go

@@ -821,15 +821,20 @@ func serverDeleteCommand() *core.Command {
 				return nil, err
 			}
 
-			if deleteServerArgs.WithIP && server.Server.PublicIP != nil && !server.Server.PublicIP.Dynamic {
-				err = api.DeleteIP(&instance.DeleteIPRequest{
-					Zone: deleteServerArgs.Zone,
-					IP:   server.Server.PublicIP.ID,
-				})
-				if err != nil {
-					return nil, err
+			if deleteServerArgs.WithIP && server.Server.PublicIPs != nil {
+				for _, ip := range server.Server.PublicIPs {
+					if ip.Dynamic {
+						continue
+					}
+					err = api.DeleteIP(&instance.DeleteIPRequest{
+						Zone: deleteServerArgs.Zone,
+						IP:   ip.ID,
+					})
+					if err != nil {
+						return nil, err
+					}
+					_, _ = interactive.Printf("successfully deleted ip %s\n", ip.Address.String())
 				}
-				_, _ = interactive.Printf("successfully deleted ip %s\n", server.Server.PublicIP.Address.String())
 			}
 
 			deletedVolumeMessages := [][2]string(nil)

internal/namespaces/instance/v1/custom_server_test.go

@@ -336,5 +336,31 @@ func Test_ServerDelete(t *testing.T) {
 		DisableParallel: true,
 	}))
 
+	t.Run("with multiple IPs", core.Test(&core.TestConfig{
+		Commands:   instance.GetCommands(),
+		BeforeFunc: core.ExecStoreBeforeCmd("Server", "scw instance server create stopped=true image=ubuntu-bionic ip=both"),
+		Cmd:        `scw instance server delete {{ .Server.ID }} with-ip=true with-volumes=all`,
+		Check: core.TestCheckCombine(
+			core.TestCheckGolden(),
+			core.TestCheckExitCode(0),
+			func(t *testing.T, ctx *core.CheckFuncCtx) {
+				t.Helper()
+
+				require.NotNil(t, ctx.Meta["Server"])
+				server := ctx.Meta["Server"].(*instanceSDK.Server)
+				assert.Len(t, server.PublicIPs, 2)
+				api := instanceSDK.NewAPI(ctx.Client)
+				for _, ip := range server.PublicIPs {
+					_, err := api.GetIP(&instanceSDK.GetIPRequest{
+						Zone: server.Zone,
+						IP:   ip.ID,
+					})
+					assert.Error(t, err, "expected IP to be deleted")
+				}
+			},
+		),
+		DisableParallel: true,
+	}))
+
 	interactive.IsInteractive = false
 }