Skip to content

Commit 29bc255

Browse files
fix(rdb): add name and version optional fields on ListDatabaseEngineRequest (#2555)
Co-authored-by: Rémy Léone <rleone@scaleway.com>
1 parent 4b30964 commit 29bc255

File tree

5 files changed

+21
-3
lines changed

5 files changed

+21
-3
lines changed

cmd/scw/testdata/test-all-usage-rdb-engine-list-usage.golden

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ USAGE:
66
scw rdb engine list [arg=value ...]
77

88
ARGS:
9+
[name] Name of the Database Engine
10+
[version] Version of the Database Engine
911
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
1012

1113
FLAGS:

docs/commands/rdb.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -446,6 +446,8 @@ scw rdb engine list [arg=value ...]
446446

447447
| Name | | Description |
448448
|------|---|-------------|
449+
| name | | Name of the Database Engine |
450+
| version | | Version of the Database Engine |
449451
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |
450452

451453

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ require (
1818
github.com/kubernetes-client/go-base v0.0.0-20190205182333-3d0e39759d98
1919
github.com/mattn/go-colorable v0.1.13
2020
github.com/mattn/go-isatty v0.0.16
21-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.9.0.20221018115351-2508d848e512
21+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.9.0.20221018125033-9a8efc64603d
2222
github.com/spf13/cobra v1.6.0
2323
github.com/spf13/pflag v1.0.5
2424
github.com/stretchr/testify v1.8.0

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ github.com/pkg/term v1.1.0/go.mod h1:E25nymQcrSllhX42Ok8MRm1+hyBdHY0dCeiKZ9jpNGw
7171
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
7272
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
7373
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
74-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.9.0.20221018115351-2508d848e512 h1:nfobEVAnoUj78XfqBoWTxvbA4QroRrjZPZcO+I1s9F4=
75-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.9.0.20221018115351-2508d848e512/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
74+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.9.0.20221018125033-9a8efc64603d h1:qzG2GUFDAjQbjY3/SQNG1gPfbUPmZBWAMAC0IQfpNjU=
75+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.9.0.20221018125033-9a8efc64603d/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
7676
github.com/sergi/go-diff v1.2.0 h1:XU+rvMAioB0UC3q1MFrIQy4Vo5/4VsRDQQXHsEya6xQ=
7777
github.com/sergi/go-diff v1.2.0/go.mod h1:STckp+ISIX8hZLjrqAeVduY0gWCT9IjLuqbuNXdaHfM=
7878
github.com/spf13/cobra v1.6.0 h1:42a0n6jwCot1pUmomAp4T7DeMD+20LFv4Q54pxLf2LI=

internal/namespaces/rdb/v1/rdb_cli.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,20 @@ func rdbEngineList() *core.Command {
213213
// Deprecated: false,
214214
ArgsType: reflect.TypeOf(rdb.ListDatabaseEnginesRequest{}),
215215
ArgSpecs: core.ArgSpecs{
216+
{
217+
Name: "name",
218+
Short: `Name of the Database Engine`,
219+
Required: false,
220+
Deprecated: false,
221+
Positional: false,
222+
},
223+
{
224+
Name: "version",
225+
Short: `Version of the Database Engine`,
226+
Required: false,
227+
Deprecated: false,
228+
Positional: false,
229+
},
216230
core.RegionArgSpec(scw.RegionFrPar, scw.RegionNlAms, scw.RegionPlWaw),
217231
},
218232
Run: func(ctx context.Context, args interface{}) (i interface{}, e error) {

0 commit comments

Comments
 (0)